Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve accessability #1028

Closed
SSilence opened this issue Mar 24, 2018 · 5 comments
Closed

improve accessability #1028

SSilence opened this issue Mar 24, 2018 · 5 comments
Labels
Milestone

Comments

@SSilence
Copy link
Member

I have some notes given by an blind user which works with an screen reader. Generally selfoss seems to be good for blind users. But some things could be improved:

  • screen readers needs an alt text for favicons (title of the entry)
<!-- icon -->
    <a href="<?= \helpers\Anonymizer::anonymize($this->item['link']); 
?>" class="entry-icon" tabindex="-1">
        <?php if (strlen(trim($this->item['icon'])) > 0 && 
$this->item['icon'] != '0') : ?>
        <img src="<?= 'favicons/' . $this->item['icon']; ?>" alt="<?= 
$title; ?>" >
        <?php endif; ?>
    </a>
  • There is no description on opened entrys
  • stream button for more should be a clickable item (button or link) not just a div
  • there should be an option that old entrys will disappear when new one loaded
@jtojnar
Copy link
Member

jtojnar commented Mar 24, 2018

  1. The favicon alt was removed intentionally, since it is the same as item title and was read twice by screen readers during my testing. Since it has tabindex="-1", it should be inert.
  2. Hmm, I though I already set correct ARIA roles there. I will fix it.
  3. I will do that after the client side refactoring.
  4. Could they elaborate on that? I thought removing content is an accessibility issue. There are supposed to be some ARIA live regions, not sure how well they are supported.

@jtojnar jtojnar added the ux label Mar 24, 2018
@SSilence
Copy link
Member Author

SSilence commented Mar 27, 2018

Thanks for the quick answer!! I will ask for details for the 4th note.

There is a 5th problem which seems to prevent blind users to use selfoss on a mobile device. The navigation can't be opened because the icon is not recognized. In home.phtml
<div id="nav-mobile-settings"></div>
should be
<div id="nav-mobile-settings" aria-label="<?= trim(\F3::get('lang_settingsbutton')); ?>" role="button"></div>

Despite this bugs selfoss seems to be the best rss reader for blind users.

@jtojnar jtojnar added this to the 2.19 milestone Apr 24, 2018
@jtojnar
Copy link
Member

jtojnar commented Sep 16, 2019

In #1133

  1. I added aria-hidden attribute to make it even more hidden.
  2. Added aria-expanded attribute but it might not be enough, future accessibility review will be necessary.
  3. Done.
  4. Not going to do that now, since I am not sure how to do that in accessible way.
  5. Done.

@akash07k
Copy link
Contributor

Great efforts @jtojnar
I'll check all these changes and will try to fix somethings my self also. Along with that, will provide more detailed insights that what are the issues and how can they be fixed. Actually, I'm myself a blind user and working as Accessibility Subject matter expert.
I am profficient in development also, but I'm not familiar with selfoss codebase. So, I'll have to understand it.

@jtojnar
Copy link
Member

jtojnar commented Sep 14, 2020

Accessibility is never done but these particular issues should be finished now. Except for 4, which is tracked by #1135. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants