-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Merge .fossa.yml
and fossa-deps.yml
#1299
Comments
Thank you @thernstig for creating this issue. If this is in regards to a defect, product question or feature request: you should use our support portal at https://support.fossa.com to file a request, as you would receive more immediate support. |
In one of the projects I'm working on we're using pnpm as a package manager. Even though FOSSA supports pnpm as a discovery strategy, the results are incorrect resulting in some of the obvious dev dependencies like typescript to be reported as direct production dependencies. We worked around this issue by dynamically generating a |
@alfrol the core problem there seems more to stem from the fact that it does not handle |
That I agree with and I already reached out to folks with that issue.
Although our workaround is a hack, I wouldn't assume that there are no more use-cases that benefit from the current design. I have a feeling that similar use-cases were exactly why folks at FOSSA decided to split the two files but of course I might be wrong. This is mentioned in the docs here though.
I don't know about that. Personally I feel more comfortable generating a separate file rather than modifying a config file and unintentionally breaking something in the configuration. Can it be done? Sure. Should it be done this way? Probably not. |
@alfrol it is very common in most tools (linters) using declarative formats to use one file. Some programming languages go even further supporting one file for all tools (pyproject.toml in Python). It is very uncommon to add a declarative configuration file for a tool in to separate files like FOSSA does, I'd say it is an outlier. |
Is your feature request related to a problem? Please describe.
Almost all open source tools out there uses one file for all its configurations needs, as its source of truth.
The FOSSA CLI has for some legacy reason opted to use both the file
.fossa.yml
andfossa-deps.yml
for its needs. This is suboptimal as disoverability for developers is harder i.e. to get a full picture of the inputs used by the FOSSA CLI when scanning.Describe the solution you'd like
Merge them.
Example:
This would simplify the setup for everyone and keep one source of truth. This does not need to be a breaking change in case
.fossa.yaml
is updated to support all top-level keys that exist infossa-deps.yml
. Deprecatefossa-deps.yml
and remove support completely in a future release.The text was updated successfully, but these errors were encountered: