Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

Enhance UI of the filter dialog #2406

Open
mayank8318 opened this issue Apr 7, 2018 · 5 comments
Open

Enhance UI of the filter dialog #2406

mayank8318 opened this issue Apr 7, 2018 · 5 comments

Comments

@mayank8318
Copy link
Contributor

Actual Behaviour

It is a standard alert dialog with a list of filters.

Expected Behaviour

Enhance the UI to use the track colours for checkboxes. Something like this -
image

Taken from Mifos self-service-app.

Steps to reproduce it

Go to schedule and open filters

Would you like to work on the issue?

Yes

@mayank8318
Copy link
Contributor Author

@iamareebjamal What is your opinion regarding this?

@iamareebjamal
Copy link
Member

@mayank8318 We need to change the implementation of filtering, so if you can take that up, this change will be included there as well

@mayank8318
Copy link
Contributor Author

@iamareebjamal I would love to do it. What exactly is required on the issue?

@iamareebjamal
Copy link
Member

Correspond to #2066

The filter functionality uses arrays and a lot of unnecessary calculation. We have to reimplement it. Basically, come up with a new solution imagining there isn't one and then change the implementation to that

@mayank8318
Copy link
Contributor Author

@iamareebjamal Ok on it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants