Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance language dropdown button #9082

Open
mariobehling opened this issue Aug 11, 2023 · 4 comments · Fixed by #9105, #9131, #9142, #9162 or #9164
Open

Enhance language dropdown button #9082

mariobehling opened this issue Aug 11, 2023 · 4 comments · Fixed by #9105, #9131, #9142, #9162 or #9164

Comments

@mariobehling
Copy link
Member

mariobehling commented Aug 11, 2023

The language dropdown button does not adhere to the design of the sidebar. The design is not a real dropdown menu. Please enhance as follows and shown in the below screenshot

  • Make it into a "real" dropdown and when the user clicks another language keep showing that language in the dropdown, e.g. the user clicks on Vietnamese, then the button should show Vietnamese.
  • Increase size of language symbol
  • Instead of "6 Languages" simply show ❻
  • Change color of font to the same as the sidebar color
  • Reduce height and width of light gray button area
  • Ensure spacing between "room name" and language dropdown even with long room names

Screenshot from 2023-08-12 00-01-11b

@mariobehling
Copy link
Member Author

Last PR does not work. Compare https://test.eventyay.com/e/a86f2bbb?side_panel=true

Screenshot from 2023-08-17 07-42-46

@mariobehling mariobehling reopened this Aug 16, 2023
@github-project-automation github-project-automation bot moved this from Done to Backlog in eventyay V2.5 Aug 16, 2023
@ntthitrinh ntthitrinh moved this from Backlog to In Review in eventyay V2.5 Aug 17, 2023
@nnhathung
Copy link
Contributor

Hi @mariobehling ,
the fix for this issue available on #9131
Please help me to review it.

@github-project-automation github-project-automation bot moved this from In Review to Done in eventyay V2.5 Aug 18, 2023
@mariobehling
Copy link
Member Author

Tested it but it has some issues

  • Clicking between channels sometimes plays the sound of the previous video
  • Clicking between languages sometimes plays both audio channels

Screenshot from 2023-08-18 09-03-22

Reopening the issue. The previous implementation did not always work perfectly neither, but it never played two audio channels at the same time.

@mariobehling mariobehling reopened this Aug 18, 2023
@github-project-automation github-project-automation bot moved this from Done to Backlog in eventyay V2.5 Aug 18, 2023
@ghost ghost moved this from Backlog to In Progress in eventyay V2.5 Aug 21, 2023
@ghost ghost moved this from In Progress to In Review in eventyay V2.5 Aug 21, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in eventyay V2.5 Aug 21, 2023
@mariobehling mariobehling reopened this Aug 26, 2023
@github-project-automation github-project-automation bot moved this from Done to Backlog in eventyay V2.5 Aug 26, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in eventyay V2.5 Aug 31, 2023
@mariobehling
Copy link
Member Author

Reopening this issue as clicking on different streams and translations does not work properly.

@mariobehling mariobehling reopened this Mar 21, 2024
@github-project-automation github-project-automation bot moved this from Done to Backlog in eventyay V2.5 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment