New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model Patcher To Work with Generics #49

Open

fabianlim opened this issue Jul 4, 2024 · 0 comments

Contributor

fabianlim commented Jul 4, 2024 •

edited

Loading

Currently the model patch is triggering on instance checks of the targeted modules. This could be converted to generics, for example

detecting based on semantics of class name. e.g. RMSNorm is a norm module
based on semantics of class instance, e.g., module.norm is a norm.

Also another consideration is to have a confg to allow the users to specifiy target hints, a la what is done for lora target_modules

Doing this, we can have generic patchers that will work on all models

However we should raise if the patching is requested, but nothing was found

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment