Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show target file first in multi-file verification #1283

Closed
wminshew opened this issue Apr 12, 2022 · 5 comments
Closed

Show target file first in multi-file verification #1283

wminshew opened this issue Apr 12, 2022 · 5 comments
Assignees
Labels
C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check D-average Difficulty: average P-normal Priority: normal T-feature Type: feature

Comments

@wminshew
Copy link

Component

Forge

Describe the feature you would like

After successfully verifying a multi-file contract, the target file should be listed first and if possible the remaining file should be listed in decreasing relevance

Additional context

After successfully verifying a multi-file contract, the target file should be listed first. Currently it looks as if foundry lists the files alphabetically (see this recent verification on master)

for files 2-n, not sure how they do it but based on my very limited experience hh seemed to do a good job of some kind of reverse relevance sorting (see older verification w hh)

debated whether to label this as a bug or feature, but feature ultimately felt more appropriate

@wminshew wminshew added the T-feature Type: feature label Apr 12, 2022
@mattsse
Copy link
Member

mattsse commented Apr 12, 2022

thanks, I think we can reverse engineer this by trying out some variations.
But etherscan knows the contract in question so curious why it doesn't put it first...

@onbjerg onbjerg added C-forge Command: forge P-normal Priority: normal D-average Difficulty: average Cmd-forge-verify Command: forge verify-contract/check labels Apr 13, 2022
@onbjerg
Copy link
Member

onbjerg commented Apr 18, 2022

@pyk You're working on this, yeah?

@pyk
Copy link
Contributor

pyk commented Apr 18, 2022

@onbjerg yes ser 👍

@mattsse
Copy link
Member

mattsse commented Apr 22, 2022

will be closed by gakonst/ethers-rs#1169

@onbjerg
Copy link
Member

onbjerg commented Apr 23, 2022

Closed by merging #1394, should be shipped in the nightly tonight :)

@onbjerg onbjerg closed this as completed Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check D-average Difficulty: average P-normal Priority: normal T-feature Type: feature
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants