Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge fails to verify multi-file contracts on windows #1382

Closed
2 tasks done
except opened this issue Apr 22, 2022 · 5 comments
Closed
2 tasks done

forge fails to verify multi-file contracts on windows #1382

except opened this issue Apr 22, 2022 · 5 comments
Labels
C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check P-normal Priority: normal T-bug Type: bug

Comments

@except
Copy link

except commented Apr 22, 2022

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

forge verify-contract

Operating System

Windows

Describe the bug

Likely an issue with the way Windows handles paths compared to Unix platforms.

@except except added the T-bug Type: bug label Apr 22, 2022
@onbjerg
Copy link
Member

onbjerg commented Apr 22, 2022

I've verified this behavior, but I'm unsure where the bug is. I suspect it might be in paths we submit to Etherscan in the Solidity standard input description

@onbjerg onbjerg added C-forge Command: forge P-normal Priority: normal Cmd-forge-verify Command: forge verify-contract/check labels Apr 22, 2022
@bavragor
Copy link

Yes seems like verifying multi file contracts is still not possible on Windows. Flattening the contract helps though.

@mattsse
Copy link
Member

mattsse commented Jun 1, 2022

any idea what we're missing?

maybe that's a metadata issue? we just switched to base-path and only relative paths and fixed another windows bug, so just to be sure verifying doesn't work with current nightly on windows?

@except
Copy link
Author

except commented Jun 2, 2022

Yes seems like verifying multi file contracts is still not possible on Windows. Flattening the contract helps though.

The fix worked for me though, maybe you haven't updated to the latest version?

@mattsse
Copy link
Member

mattsse commented Jun 2, 2022

thanks for letting us know @except

optimistically closing this, but please let us know if you're still having issues @bavragor

@mattsse mattsse closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check P-normal Priority: normal T-bug Type: bug
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants