Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix solang breaking issues in fmt #1611

Closed
2 tasks
mattsse opened this issue May 13, 2022 · 2 comments
Closed
2 tasks

Fix solang breaking issues in fmt #1611

mattsse opened this issue May 13, 2022 · 2 comments
Labels
C-forge Command: forge Cmd-forge-fmt Command: forge fmt T-bug Type: bug

Comments

@mattsse
Copy link
Member

mattsse commented May 13, 2022

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

No response

Describe the bug

There were quite a few changes in Solang, especially the AST model, which broke the fmt box in a non-trivial way.

as a stopgap fmt was disabled in #1610

before we can reenable it, the formatter and visitor need to updated.

cc @shekhirin @rkrasiuk
@mattsse mattsse added T-bug Type: bug Cmd-forge-fmt Command: forge fmt labels May 13, 2022
@gakonst
Copy link
Member

gakonst commented May 13, 2022

ref #1612

@onbjerg onbjerg added the C-forge Command: forge label May 14, 2022
@mattsse
Copy link
Member Author

mattsse commented May 21, 2022

closed by #1612

@mattsse mattsse closed this as completed May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-forge Command: forge Cmd-forge-fmt Command: forge fmt T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@onbjerg @gakonst @mattsse