Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge dumps full private key out into the terminal if it can't parse it properly #6374

Closed
2 tasks done
morelazers opened this issue Nov 20, 2023 · 2 comments · Fixed by #6375
Closed
2 tasks done

forge dumps full private key out into the terminal if it can't parse it properly #6374

morelazers opened this issue Nov 20, 2023 · 2 comments · Fixed by #6375
Labels
T-bug Type: bug

Comments

@morelazers
Copy link

morelazers commented Nov 20, 2023

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (529559c 2023-11-13T00:19:35.957961000Z)

What command(s) is the bug in?

forge script etc.

Operating System

macOS (Apple Silicon)

Describe the bug

Would be nice if the private key was at least masked a little bit. I know there are probably times where it doesn't know what it's parsing, but when the env variable is called PRIVATE_KEY maybe there's a way.

@morelazers morelazers added the T-bug Type: bug label Nov 20, 2023
@mattsse
Copy link
Member

mattsse commented Nov 20, 2023

can you please give a bit more context?
ideally the sol code responsible for reading the env var?

@morelazers
Copy link
Author

vm.startBroadcast(vm.envUint("PRIVATE_KEY"));

I realise now that this is a variable of my own naming. I got here because I couldn't figure out why forge script my/script.sol --broadcast -i wasn't asking for my private key to broadcast the transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants