Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Dice So Nice damage type #4248

Open
JiDW opened this issue Sep 15, 2024 · 1 comment · May be fixed by #4496
Open

Adding support for Dice So Nice damage type #4248

JiDW opened this issue Sep 15, 2024 · 1 comment · May be fixed by #4496
Assignees
Milestone

Comments

@JiDW
Copy link

JiDW commented Sep 15, 2024

Hello,

I've received multiple requests on Dice So Nice repository since dnd5e v3 and the change done to damage type from the core "flavor" feature to system-specific damageroll.options.type. People could previously see dice skins based on the type of damage dealt (fire, ice, etc).
This feature was enabled by default but could be turned off.

I'm opening this ticket for these users and providing insider info if you want to add this feature.
If not, it can be the base for a tiny module someone else could develop.

Dice So Nice will use any info under roll.options.appearance or diceterm.options.appearance to override current user dice appearance.

This means doing this somewhere in the dnd5e code:

mydamageroll.options.appearance = {colorset: mydamageroll.options.type};

Corresponding documentation: https://gitlab.com/riccisi/foundryvtt-dice-so-nice/-/wikis/API/Customization#changing-the-appearance-of-dice-in-a-roll-programmatically

However, please note that this feature could previously be turned off by disabling a Dice So Nice feature that looks at the dice favor value (like 1d8[fire]).
So doing this without having a corresponding user setting would prevent users from disabling the damage type appearance override.

nb: It was previously not possible to pass an appearance directly to a Roll object, only to individual DiceTerms. I've added this QOL feature in the newest version of Dice So Nice to simplify this kind of use-case.

Related DsN ticket: https://gitlab.com/riccisi/foundryvtt-dice-so-nice/-/issues/401

@roth-michael
Copy link
Contributor

Commenting for assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants