Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Skip Dialog keybindings for skipping Activity Selection & Activity Usage Dialog windows #4596

Open
arbron opened this issue Oct 24, 2024 · 0 comments · May be fixed by #4599
Open

Use Skip Dialog keybindings for skipping Activity Selection & Activity Usage Dialog windows #4596

arbron opened this issue Oct 24, 2024 · 0 comments · May be fixed by #4599
Assignees
@arbron
Labels
accessibility ux User experience related features or bugs
Milestone
D&D5E 4.2.0

Comments

@arbron
Copy link
Collaborator

arbron commented Oct 24, 2024

We use these keybindings for roll dialogs, but currently the Activity Selection dialog is hardcoded to use the "Shift" key and the Activity Usage Dialog doesn't support any skip button.
@arbron arbron added ux User experience related features or bugs accessibility labels Oct 24, 2024
@arbron arbron added this to the D&D5E 4.1.0 milestone Oct 24, 2024
@arbron arbron self-assigned this Oct 25, 2024
arbron added a commit that referenced this issue Oct 25, 2024
@arbron
[#4596] Allow activity usage dialog to be skipped
26c52f1 
Uses the various "Skip Dialog" keybindings to skip the activity
usage dialog, using the activity with the default configuration.
Does some modifications for the `ActivityChoiceDialog` to return
an event so the usage dialog can be skipped from there also.

The same keybindings will now also skip the activity choice dialog
rather than just being hardcoded to the Shift key. This does not
yet attempt to change the hint displayed in the UI of that dialog.

Closes #4596
@arbron arbron linked a pull request Oct 25, 2024 that will close this issue
Open
arbron added a commit that referenced this issue Nov 4, 2024
@arbron
[#4596] Display updating shortcut hint, other PR feedback
c74cf1c
@arbron arbron modified the milestones: D&D5E 4.1.0, D&D5E 4.2.0 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
accessibility ux User experience related features or bugs
Projects
None yet
Milestone
D&D5E 4.2.0
Development

Successfully merging a pull request may close this issue.

[#4596] Allow activity usage dialog to be skipped foundryvtt/dnd5e
1 participant
@arbron