Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat buttons after issuing Barracks enlarge order throw errors #4714

Open
krbz999 opened this issue Nov 13, 2024 · 1 comment · May be fixed by #4719
Open

Chat buttons after issuing Barracks enlarge order throw errors #4714

krbz999 opened this issue Nov 13, 2024 · 1 comment · May be fixed by #4719
Assignees
@arbron
Labels
bug Functionality which is not working as intended system: bastions
Milestone
D&D5E 4.1.2

Comments

@krbz999
Copy link
Contributor

krbz999 commented Nov 13, 2024

repro:

  • add Barracks facility to actor
  • click Barracks facility
  • issue Enlarge order
  • click any resulting button in chat

image
@arbron arbron added bug Functionality which is not working as intended system: bastions labels Nov 13, 2024
@arbron arbron added this to the D&D5E 4.1.2 milestone Nov 13, 2024
@arbron
Copy link
Collaborator

arbron commented Nov 13, 2024

Looks like this is happening because the synthetic activity we use for the Enlarge order is no longer available on the item because it has been fully enlarged.

@arbron arbron self-assigned this Nov 13, 2024
arbron added a commit that referenced this issue Nov 13, 2024
@arbron
[#4714] Fix error when using chat action for deleted activity
b859aec 
Fixes an issue caused by enlarging special bastion facilities to
their maximum size, which caused the Enlarge activity to be
removed, and thus no subsequent chat actions could be triggered.

This fix covers the immediate problem, but the chat actions will
still not be usable if the player refreshes or the chat message
is re-rendered, because this fix only works because the deleted
activity is still held in memory as part of the event handler.

Closes #4714
@arbron arbron linked a pull request Nov 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
bug Functionality which is not working as intended system: bastions
Projects
None yet
Milestone
D&D5E 4.1.2
Development

Successfully merging a pull request may close this issue.

[#4714] Fix error when using chat action for deleted activity foundryvtt/dnd5e
2 participants
@arbron @krbz999