Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: profiles should mandate versions #710

Open
wkalt opened this issue Nov 5, 2022 · 1 comment
Open

spec: profiles should mandate versions #710

wkalt opened this issue Nov 5, 2022 · 1 comment
Labels
feature New feature or request

Comments

@wkalt
Copy link
Contributor

wkalt commented Nov 5, 2022

The meaning of a profile could potentially evolve with time. To counteract that, it would be useful for profiles to specify a version.

I think the only reasonable way to do this with the current spec would be to require a specifically-named metadata record. If we roll a V1 at some point we could consider attaching arbitrary k/v data to the Header record where this could potentially live.
@wkalt wkalt added the feature New feature or request label Nov 5, 2022
@wkalt wkalt changed the title spec: profiles should mandate versions in header spec: profiles should mandate versions Nov 5, 2022
@MichaelOrlov
Copy link
Contributor

What if we will include profile version in the profile name?

For instance similar as in https://github.com/foxglove/mcap/blob/main/docs/specification/appendix.md#ros2:

ROS2v1
The ros2 profile describes how to create MCAP files for ROS 2.

Header

  • profile: MUST be ros2v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wkalt @MichaelOrlov