From 9ea5042c3a78126c09b03daff2b682db4535aba1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Chalifour?= Date: Wed, 12 Feb 2020 10:31:34 +0100 Subject: [PATCH] fix(getters): compute `aria-autocomplete` based on the props --- packages/autocomplete-core/propGetters.ts | 2 +- packages/autocomplete-core/types/propGetters.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/autocomplete-core/propGetters.ts b/packages/autocomplete-core/propGetters.ts index 0395d38cb..b3620403c 100644 --- a/packages/autocomplete-core/propGetters.ts +++ b/packages/autocomplete-core/propGetters.ts @@ -125,7 +125,7 @@ export function getPropGetters({ const { inputElement, ...rest } = providedProps; return { - 'aria-autocomplete': 'both', + 'aria-autocomplete': props.showCompletion ? 'both' : 'list', 'aria-activedescendant': store.getState().isOpen && store.getState().highlightedIndex >= 0 ? `${props.id}-item-${store.getState().highlightedIndex}` diff --git a/packages/autocomplete-core/types/propGetters.ts b/packages/autocomplete-core/types/propGetters.ts index e80f377ff..08a5d5fd1 100644 --- a/packages/autocomplete-core/types/propGetters.ts +++ b/packages/autocomplete-core/types/propGetters.ts @@ -39,7 +39,7 @@ export type GetInputProps = (props: { autoCorrect: 'on' | 'off'; autoCapitalize: 'on' | 'off'; spellCheck: boolean; - 'aria-autocomplete': 'both'; + 'aria-autocomplete': 'none' | 'inline' | 'list' | 'both'; 'aria-activedescendant': string | null; 'aria-controls': string | null; 'aria-labelledby': string;