Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS REVIEW] NotImplementedError Remarks #23

Closed
RyanSwindeman opened this issue Apr 18, 2023 · 2 comments
Closed

[JOSS REVIEW] NotImplementedError Remarks #23

RyanSwindeman opened this issue Apr 18, 2023 · 2 comments

Comments

@RyanSwindeman
Copy link

@frank1010111 could you please comment on the NotImplementedErrors we see in flow/reservoir.py's MultiPhaseReservoir? Thanks for any information.

This is part of the reviewing process for JOSS: openjournals/joss-reviews#5255
@frank1010111
Copy link
Owner

frank1010111 commented Apr 18, 2023 •
edited
Loading

Yes, this is planned future functionality in #3 that would be nice to have, but its effect on tight-oil production matching and forecasting has not yet been studied.

@RyanSwindeman RyanSwindeman changed the title [JOSS REVIEW] [JOSS REVIEW] NotImplementedError Remarks May 1, 2023
@RyanSwindeman
Copy link
Author

Understood. Thanks for the explanation. Looking forward to that one day in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frank1010111 @RyanSwindeman