From ed63f5a7059d0b42858e63484e2d0eb2e7893721 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Fri, 15 Dec 2023 14:30:03 +0530 Subject: [PATCH] fix: journals as invoice throwing validation error (backport #1185) (#1187) allocating payment entries against multi-currency journal entries as invoice with the same exchange rate should not create gain_loss journals (cherry picked from commit 50eaaca21eb14f2f1462b805c43b780a700de04e) Co-authored-by: ruthra kumar --- hrms/overrides/employee_payment_entry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hrms/overrides/employee_payment_entry.py b/hrms/overrides/employee_payment_entry.py index 1b4131a59b..1dc87b05ea 100644 --- a/hrms/overrides/employee_payment_entry.py +++ b/hrms/overrides/employee_payment_entry.py @@ -42,7 +42,7 @@ def set_missing_ref_details( ) for field, value in ref_details.items(): - if d.exchange_gain_loss: + if d.exchange_gain_loss is not None: # for cases where gain/loss is booked into invoice # exchange_gain_loss is calculated from invoice & populated # and row.exchange_rate is already set to payment entry's exchange rate