-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attendance is applied twice for same employee and same day #1086
Comments
Its not a bug its a feature |
Dont assign multiple shifts to the employee on the same day if you dont want to use this feature |
@ruchamahabal I don't think it is a feature. Also, accidentally if someone is assigned with two shifts then the system should not apply present for same day twice. I can understand its a user mistake of assigning two shifts to a single employee but as a product it looks like a bug to the end user and the system should restrict the same. |
If you don't want to use this feature, you can restrict this by a simple server script validation for now. We will add a feature flag to disable this feature later. The feature is being used by many customers currently |
I can do the server script to stop this but I believe nobody wants confusing attendance and specially if the number of days in a month is 30 and you get 43 attendance is very much like a bug. |
As per standard HR policies, if you work multiple shifts a day, you get paid more so this is via a valid use case. But we understand it does not fit your case.
As I said we will address this by introducing a feature flag to allow disabling this. We are not denying that we won't do anything about this. |
It can't fit into anybody's case. Even if you're working in two shifts the employee will be paid Overtime but not the attendance twice. |
We have government companies who asked for this feature (and are using it) where employees work 2 4-hour shifts (morning & night). They need to calculate and mark attendance per shift so 2 attendance records. Several other HR solutions also provide this feature btw. |
I am okay with the feature, but still not convinced why someone will need a double present for a single day. In fact, when we try to apply attendance via Attendance doctype twice for the same day it provides a validation error. |
If it's without any shift it means attendance is for the whole day and hence the validation is thrown. If these three cases are not true meaning attendance is being marked for 2 non-overlapping shifts, the system allows |
Information about bug
The system is creating multiple attendances for the same day / same employee but different shifts.
The attendance is prepared via Employee Checkin and using mark auto attendance.
See attached screenshot.
Module
HR
Version
ERPNext: v14.48.1 (HEAD)
Frappe Framework: v14.55.0 (HEAD)
Frappe HR: v14.16.1 (HEAD)
Installation method
FrappeCloud
Relevant log output / Stack trace / Full Error Message.
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: