Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect LWP Calculation for Leave Types Including Holidays on Salary Slip #1573

Closed
1 task done
KerollesFathy opened this issue Mar 24, 2024 · 2 comments · Fixed by #1578
Closed
1 task done

Incorrect LWP Calculation for Leave Types Including Holidays on Salary Slip #1573

KerollesFathy opened this issue Mar 24, 2024 · 2 comments · Fixed by #1578
Labels
bug Something isn't working released

Comments

@KerollesFathy
Copy link
Contributor

KerollesFathy commented Mar 24, 2024

Information about bug

The calculate_lwp_or_ppl_based_on_leave_application function in the Salary Slip has a bug related to calculating Leave Without Pay (LWP) when leave types include holidays. The issue stems from referencing the incorrect attribute name (include_holidays instead of include_holiday) in the function's logic.

Proposed Solution

Update the attribute name from include_holidays to include_holiday in the calculate_lwp_or_ppl_based_on_leave_application function.

Module

Payroll

Version

  • Frappe : v15.18.2
  • ERPNext: v15.17.5
  • HRMS: v15.14.2

Installation method

FrappeCloud

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@KerollesFathy KerollesFathy added the bug Something isn't working label Mar 24, 2024
@KerollesFathy
Copy link
Contributor Author

KerollesFathy commented Mar 24, 2024

Fixes #1574

@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
3 participants