From 22a861de98e9ad6571a537e469a72580d21e350a Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Tue, 19 Dec 2023 12:42:54 +0530 Subject: [PATCH] Revert "fix: journals as invoice throwing validation error" (#1192) This reverts commit 50eaaca21eb14f2f1462b805c43b780a700de04e. (cherry picked from commit 1bcc636b0108629ae547e6467c8aba8f90d2c72d) --- hrms/overrides/employee_payment_entry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hrms/overrides/employee_payment_entry.py b/hrms/overrides/employee_payment_entry.py index 1dc87b05ea..1b4131a59b 100644 --- a/hrms/overrides/employee_payment_entry.py +++ b/hrms/overrides/employee_payment_entry.py @@ -42,7 +42,7 @@ def set_missing_ref_details( ) for field, value in ref_details.items(): - if d.exchange_gain_loss is not None: + if d.exchange_gain_loss: # for cases where gain/loss is booked into invoice # exchange_gain_loss is calculated from invoice & populated # and row.exchange_rate is already set to payment entry's exchange rate