From 3d2c20d33401f7f12b6eaeb983e32418f8e97c00 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Fri, 5 Apr 2024 20:38:03 +0530 Subject: [PATCH] fix: use reference name while updating exc rate (#1623) (cherry picked from commit a24fbd0638f4b043200a044b187f3e7fe968e807) --- hrms/overrides/employee_payment_entry.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hrms/overrides/employee_payment_entry.py b/hrms/overrides/employee_payment_entry.py index ec8ce5df86..8fb2a0bba4 100644 --- a/hrms/overrides/employee_payment_entry.py +++ b/hrms/overrides/employee_payment_entry.py @@ -31,7 +31,7 @@ def set_missing_ref_details( self, force: bool = False, update_ref_details_only_for: list | None = None, - ref_exchange_rate: float | None = None, + reference_exchange_details: dict | None = None, ) -> None: for d in self.get("references"): if d.allocated_amount: @@ -45,8 +45,12 @@ def set_missing_ref_details( ) # Only update exchange rate when the reference is Journal Entry - if ref_exchange_rate and d.reference_doctype == "Journal Entry": - ref_details.update({"exchange_rate": ref_exchange_rate}) + if ( + reference_exchange_details + and d.reference_doctype == reference_exchange_details.reference_doctype + and d.reference_name == reference_exchange_details.reference_name + ): + ref_details.update({"exchange_rate": reference_exchange_details.exchange_rate}) for field, value in ref_details.items(): if d.exchange_gain_loss: