-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to type in the "ż" Polish letter #518
Comments
OK, it seems that the issue is simply based around checking that the alt key is not pressed in the undoManager. Looks like a simple fix but I'll need some time to do it. As a side note, 1.3.0 has an official release now! |
Ok, thanks. I will await an update. |
Hi, would it be possible to have a target date for this bug? |
Hmmm, it should be fixed in 1.3.6. Not sure how I managed to slip that past the changelog/commits process. https://github.com/fraywing/textAngular/blob/v1.3.6/lib/taBind.js#L455 Can someone confirm this fixes it please? |
Hi, I just upgraded textAngular form 1.2.2 to 1.3.6, and "ż" don't work any more ;) |
Hmm, thanks for letting me know, I'll have another look when I get the chance. |
Got some feedback from Polish user. Here you can find the complete list of Polish special letters: ęóąśłżźćń All of them can be typed in as Right ALT + latin letter on Polish Programmers keyboard, for instance ł = Righ Alt + L |
I think I've fixed this this time. I've also added in a test to check this time - Triggering Alt + Ctrl + Z doesn't fire the undo command now which from what I understand is the problem. Can someone grab the version from master and confirm this please? If not - reopen the issue please. |
Yep it's working perfectly now. |
hi SimeonC, I am a developer from China. I look forward to your reply Thanks & Best Regards, |
@tongjyqueen previews issue was fixed by #580 it was related to shortcuts capture in textAngular (I would start form checking version of the libs) ^_^ |
Using texAngular version v1.3.0-pre14, I'm unable to type the "ż" Polish letter. It performs an undo action, removing charcters that were previously typed, instead of adding the ż. It can be pasted in, but we need to be able to type it in since there are many Polish words with this letter and it's not an acceptable work around to paste it every time. I also tried upgrading to the latest version 1.3.3. and still see the problem. I am using Windows 7, and tried on IE 10, Chrome 40.0.2214.93, and FF 31.4.0 ESR.
Steps:
I see some similar issues in other projects at these links:
http://www.tinymce.com/forum/viewtopic.php?id=783
tiff/wysihtml5#16
https://tracker.moodle.org/browse/MDL-47133
Any thoughts on this?
The text was updated successfully, but these errors were encountered: