-
-
Notifications
You must be signed in to change notification settings - Fork 359
add email service with nodemailer #146
add email service with nodemailer #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor changes
Note to self: Have to raise another issue, as according to @QuincyLarson comment, we have to support popular options like Amazon SES, SendGrid, and Mandrill.
@@ -80,6 +80,9 @@ Install dependencies: | |||
npm install | |||
``` | |||
|
|||
Setup Environment Variables: | |||
Copy and paste env.sample into your .env file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using a ".env" file in Docker Compose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't know much at all about Docker -- Do you mean that we should use environment variables in Docker Compose for default variables that can be overwritten by an .env file?
@vaibhavsingh97 @eolculnamo2 would we need to enable all the transports, by default, to support the common options? Looks like SMTP is the default and then SES and sendmail (local relay) need to be enabled. So, would we be installing everything even if people only will use one transport? |
Hi, I can look into this |
Hi @ALL, I need to dive into |
Nope, by default only SMTP will be enabled, we will just provide options to enable all other providers.
Nope, We will give options to users, if they want to use other services. |
How would installing new mailer packages work for the app? Would the administrator need to run a command on the server, or is there a way to install new packages directly from the application admin UI and/or configuration files? |
@allella nodemailer uses plugins for non SMTP transports (has some build in), to avoid manually installing them, they need to already exist, its best to view these diff plugins as a "preset" (needs its own config page to fill in params) to be selected, I am looking into that as well to put in MVP, it seems to be very trivial to add in the various plugins for node-mailer, still investigating... |
@eolculnamo2 Can you please resolve conflicts so that we can merge 😄 |
Will do :) |
Also, Can you please resolve @ScottBrenner comment, also as you had added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We had more current conversation in today's meeting on using nodemailer and SMTP with free / cheap tiers of 3rd party transactional mailing services. |
Update README.md
).master
branch of Chapter.Creates Email Service using nodemailer that will be used later for our email tickets.
Dependencies Added: