fix page redirects across all pages #515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by: Dylan Uribe <[email protected]> Co-authored by: Ann Pan <[email protected]>
This reverts commit 8339fea.
Co-authored-by: Dylan Uribe <[email protected]> Co-authored-by: Ann Pan <[email protected]>
Co-authored-by: Dylan Uribe <[email protected]> Co-authored-by: Ann Pan <[email protected]>
senthil1288
reviewed
Dec 4, 2023
ngillux
reviewed
Feb 10, 2024
| }; | ||
| }; | ||
|
|
||
| export default redirectUser; |
There was a problem hiding this comment.
Tested the PR by doing the following (all checks resulted as expected):
- Initially signing in as user ‘NONE’ which is the default user when first signing on to the app -> this correctly showed the ‘Access Denied’ UI as intended
- Initially signing in as user ‘STUDENT’ -> this correctly showed the ‘Access Denied’ UI as intended
- Initially signing in as user ‘TEACHER’ -> this correctly shows the class creation UI as intended
- Initially signing in as user ‘ADMIN’ -> this correctly displays the admin dashboard
Edge case to consider:
When updating the user privileges in Prisma, the UI does not update immediately as the link is still set to https://{CODESPACES}.app.github.dev/error. This could mean that logic may need to be added which would update the URL (‘error’, ‘admin’, ‘teacher’, ‘student’) once a user privilege is updated.
Mentioning @utsab for further view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Co-authored by: Dylan Uribe [email protected]
Co-authored by: Ann Pan [email protected]
Thank you to SenthilKumar Ilango [email protected] for mentoring us.
Resolved Issue #497 and refactored all page redirects. Redirects were previously handled with ctx.writeHead, but we replaced it with our method called redirectUser which uses the recommended page redirect instruction provided by next.js. (https://nextjs.org/docs/pages/api-reference/functions/get-server-side-props#redirect) Tested changes locally.
Closes #497