Soycode shippabletravis #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 30, 2015 14:04
…s/radiatus-providers into soycode-shippabletravis
…s/radiatus-providers into soycode-shippabletravis
…s/radiatus-providers into soycode-shippabletravis
|
Tests now kinda run on Shippable courtesy of f519731. They don't actually pass, but that may be a separate issue from this PR. Let me know your thoughts, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22 - however, the tests don't actually get all that far yet. Specifically it dies on:
However, I get the same issue locally, so it's likely not an issue with this ci code. I did a bit of perusing and it seems like it may have to do with Browserify (https://www.npmjs.com/package/gulp-browser is suggested as a possible fix). But having tests pass and having them run on ci are two separate problems, so I figured I'd make the pull request for discussion at least.
Thanks!