Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile target fetch-wheels changes the timestamp of the wheels #46

Closed
kushaldas opened this issue May 31, 2019 · 2 comments
Closed

Makefile target fetch-wheels changes the timestamp of the wheels #46

kushaldas opened this issue May 31, 2019 · 2 comments

Comments

@kushaldas
Copy link
Contributor

The fetch-wheels makefile target changes the timestamp of the wheel files. This means when I try to resync the localwheels directory to the S3 bucket, it sync all the files again.

We should modify the script so that it can keep the original timestamp of the files.

@conorsch

@conorsch
Copy link
Contributor

The lack of reliable timestamps during fetch is a side-effect of using object storage buckets for the wheels, rather than, say, rsync via ssh. Fetching over HTTPS simply doesn't afford an opportunity to compare timestamps.

One option may be to pass --exact-timestamps when pulling from S3, rather than fetching via curl or wget. See aws s3 sync help for more info. We'll still need to trust checksums and signatures in order to verify integrity, rather than skipping based on timestamp, given that the --exact-timestamps flag appears to be relevant only for pulls from, rather than pushes to, S3.

See also the --size-only option to s3 sync, which would skip uploads based on filesize. Take it for a spin and comment on what you see as the best approach, @kushaldas.

Before making any changes to the recommended workflow, let's make sure to tackle #55 so we're updating the documentation accordingly.

@conorsch
Copy link
Contributor

As of #124, we're no longer using S3 for storing the binary wheel feels. Instead, we use git-lfs, so the files will be present locally—without needing to "fetch" via a separate action—and timestamps will persist from whenever they were pulled in via git. Additional metadata about time of creation via commit is of course available via standard git tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants