Remove files related to Debian packaging, now in client repo #490
Conversation
legoktm
force-pushed
the
rm-packaging
branch
2 times, most recently
from
6c6ca1e
to
608744f
Compare
All of the packaging logic has moved to the securedrop-client repository, leaving this responsible for the localwheels building. (RPM nightlies will be moved out at a later time.) Nearly everything has been migrated, the things that haven't (lint-desktop-files, test_deb_package.py and clean-old-packages) have open issues/PRs for them. One explicit workflow change is that PRs to this repo will not test package builds, because doing so causes a catch-22 scenario when the build-requirements.txt in the client repo hasn't been updated yet, so it fails.
legoktm
force-pushed
the
rm-packaging
branch
2 times, most recently
from
0e921f8
to
04b6481
Compare
There was a problem hiding this comment.
I noticed this file isn't present in securedrop-client after the refactor changes. Is that intentional?
There was a problem hiding this comment.
Yep, we are no longer using dh-virtualenv so there's no trigger for us to register on to. (And the triggers file was mostly useless too, c.f. freedomofpress/securedrop#6231)
There was a problem hiding this comment.
Same as previous - I may be missing something about the refactor but are we missing some workstation-viewer package config in the client repo now?
There was a problem hiding this comment.
The workstation-viewer package is just a "metapackage", it doesn't contain any files of its own, just depends on other packages, so it's fully contained in the d/control file now: https://github.com/freedomofpress/securedrop-client/blob/main/debian/control#L47
best way to verify this is build the new debs in the client, grab an old deb from apt-prod and diffoscope them :)
All of the packaging logic has moved to the securedrop-client repository, leaving this responsible for the localwheels building. (RPM nightlies will be moved out at a later time.)
Nearly everything has been migrated, the things that haven't (lint-desktop-files, test_deb_package.py and clean-old-packages) have open issues/PRs for them.
One explicit workflow change is that PRs to this repo will not test
package builds, because doing so causes a catch-22 scenario when the
build-requirements.txt in the client repo hasn't been updated yet, so it
fails.