We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None of the subprocess.run calls have any error handling. Either check=True should be passed or the return code should be explicitly checked.
subprocess.run
check=True
>>> subprocess.run(['false']) CompletedProcess(args=['false'], returncode=1) >>> subprocess.run(['false'], check=True) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib64/python3.9/subprocess.py", line 528, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['false']' returned non-zero exit status 1.
It's also unclear to me why we shell out to cp instead of using shutil.copy2().
cp
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
None of the
subprocess.run
calls have any error handling. Eithercheck=True
should be passed or the return code should be explicitly checked.It's also unclear to me why we shell out to
cp
instead of using shutil.copy2().The text was updated successfully, but these errors were encountered: