Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How we want to display dates, times, and timestamps #332

Closed
sssoleileraaa opened this issue Apr 25, 2019 · 1 comment · Fixed by #719
Closed

How we want to display dates, times, and timestamps #332

sssoleileraaa opened this issue Apr 25, 2019 · 1 comment · Fixed by #719

Comments

@sssoleileraaa
Copy link
Contributor

Description

To format dates and times in the client, we use arrow, which supports a growing list of contributed locales (see https://github.com/crsmithdev/arrow/blob/master/arrow/locales.py). We currently use (humanize)[https://arrow.readthedocs.io/en/latest/#humanize] to format all of our times.

In order to show dates and times as they appear in the Zeplin Screen below (see the four different locations), we will need to update our code that calls humanize.

date-times
Note: In this Zeplin Screen there is a time since last refresh that appears next to the refresh icon and a time since last source message that appears in 3 different locations: the source list for each entry, the bottom of the last message in the conversation view, and the title bar of the conversation view.

@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented Apr 29, 2019

Per client sync discussion:

  • display day month in the source list and conversation header as shown in Zeplin
  • display day month time in the bottom right corner of the conversation view
  • display day month year time in the bottom right corner of the conversation view if the year is before the current year
  • display time timezone for last refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants