Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrinking size of window can cause sources in the source list to disappear #613

Closed
redshiftzero opened this issue Nov 8, 2019 · 4 comments
Labels
bug Something isn't working component/UI help wanted Extra attention is needed

Comments

@redshiftzero
Copy link
Contributor

Description

When you decrease the size of the window, sources can disappear. I've observed this for two sources in the dev env, I decreased the size of the window at only the top (active) source stayed there, the second source disappeared.

Steps to Reproduce

  1. Log into client
  2. Reduce size of window

Expected behavior

All sources continue to appear in the source list

Actual behavior

One source disappears from the source list

@redshiftzero redshiftzero added bug Something isn't working help wanted Extra attention is needed component/UI labels Nov 8, 2019
@deeplow
Copy link
Contributor

deeplow commented Nov 13, 2019

I think I've seen this one before. Just want to make sure this is the one.

I'm using i3 and when I maximise the window the following happens sometimes
sd-pic

The source is still on the list and can be selected but the text is not visible
sd-pic2

After a while it fixed itself (probably an automatic refresh)
sd-pic3

@sssoleileraaa
Copy link
Contributor

This bug was reintroduced after #330 was merged. Instead of using the default Qubes selection styling, we want to use our own, but there's this show-decoration-selected:0 bug reported here: #331 (comment)

@sssoleileraaa
Copy link
Contributor

More specifically:

If you remove this line of code the issue is fixed:

https://github.com/freedomofpress/securedrop-client/blob/master/securedrop_client/gui/widgets.py#L840

But we need a better fix/ workaround that doesn't force us to use Qubes selection decoration style.

@sssoleileraaa
Copy link
Contributor

closing because this is a duplicate of: #331
(I'll update its title to be more clear)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/UI help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants