Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push our own nightlies to securedrop-yum-test #955

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Push our own nightlies to securedrop-yum-test #955

merged 1 commit into from
Apr 15, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Feb 28, 2024

Status

Ready for review

Description of Changes

Take this responsibility over from securedrop-builder.

Refs freedomofpress/securedrop-builder#482.

Testing

Deployment

Any special considerations for deployment? n/a

Copy link
Member Author

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging updates needed now

.github/workflows/nightlies.yml Outdated Show resolved Hide resolved
.github/workflows/nightlies.yml Outdated Show resolved Hide resolved
@legoktm legoktm force-pushed the nightlies branch 2 times, most recently from 13ad0eb to d27b82d Compare April 11, 2024 18:47
@legoktm
Copy link
Member Author

legoktm commented Apr 11, 2024

Workflow seems ready; pending infra generating a PAT, requested at https://github.com/freedomofpress/infrastructure/issues/4749.

@legoktm legoktm force-pushed the nightlies branch 2 times, most recently from 49ef23d to 700c7b2 Compare April 11, 2024 22:27
Take this responsibility over from securedrop-builder.

Refs <freedomofpress/securedrop-builder#482>.
@legoktm legoktm force-pushed the nightlies branch 2 times, most recently from 6c09bf1 to eb9243f Compare April 12, 2024 00:15
@legoktm legoktm requested a review from eloquence April 12, 2024 00:18
@legoktm
Copy link
Member Author

legoktm commented Apr 12, 2024

Token has been set by infra, I tested and fixed the workflow and moved it to ready for review \o/

Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's give it a try. TIL about artifact actions.

@eloquence eloquence added this pull request to the merge queue Apr 15, 2024
@eloquence
Copy link
Member

As a side note, should we split make install-deps? It's installing Qt-related dependencies -- are these actually needed for this workflow? If it makes sense to split, I'll open a separate issue to track.

Merged via the queue into main with commit 2f0184d Apr 15, 2024
6 of 7 checks passed
@legoktm legoktm deleted the nightlies branch April 16, 2024 14:52
@legoktm
Copy link
Member Author

legoktm commented Apr 16, 2024

As a side note, should we split make install-deps? It's installing Qt-related dependencies -- are these actually needed for this workflow? If it makes sense to split, I'll open a separate issue to track.

Yeah, probably time to split it, as it's currently a mix of dev/test and build dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants