Migrate cleanup workflow to GitHub Actions #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloquence
force-pushed
the
migrate-cleanup-to-gha
branch
from
062bcca
to
4f7d413
Compare
eloquence
changed the title
eloquence
force-pushed
the
migrate-cleanup-to-gha
branch
2 times, most recently
from
fa582a2
to
7b9f327
Compare
The `clean-old-packages` script was adapted from the `securedrop-builder` repository and originally written by Kunal Mehta.
eloquence
force-pushed
the
migrate-cleanup-to-gha
branch
from
7b9f327
to
4f7d904
Compare
eloquence
changed the title
|
(I believe this is ready for a review pass anytime, but I'll open a cleanup PR to remove the migrated job on |
eloquence
commented
Apr 9, 2024
| This script is run in CI in a Fedora container. You can spin up a similar | ||
| container locally using podman or docker, e.g.: | ||
|
|
||
| podman run -it --rm -v $(pwd):/workspace:Z fedora:39 bash |
There was a problem hiding this comment.
Probably the trickiest part was to get the script running locally on a non-Fedora system, so I added this to help with bootstrapping.
legoktm
reviewed
Apr 9, 2024
|
d5ac35b - awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of freedomofpress/securedrop-builder#482
Description
Adds a GitHub action to preserve 4 packages for nightlies & regular workstation packages in yum-test. Note that this reduces the number of nightlies to 4 (from 7), consistent with the
securedrop-apt-testworkflow for nightlies (https://github.com/freedomofpress/securedrop-apt-test/blob/main/.github/workflows/cleanup.yml).The
clean-old-packagesscript was adapted from thesecuredrop-builderrepository and originally written by Kunal Mehta.Testing
PUSH_TOKEN, we can, but since this is only a cleanup job that can fail for a few days without breaking anything, I figure it's also safe to land and troubleshoot if it fails to push as expected.