-
Notifications
You must be signed in to change notification settings - Fork 685
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't register trigger on Python for securedrop-app-code package
We currently register a trigger with the Python interpreter so dh_virtualenv can fix up the interpreter's symlinks in case something changes as recommended in their docs[1]. However, our packages are designed for a single Ubuntu release, which keeps the same version of Python for its entire lifetime, so the interpreter in the venv will always be a symlink to `/usr/bin/python3` and the dh_virtualenv postinst code will always be a no-op because it skips all symlinks. This was noticed because our custom postinst was not handling the "triggered" state, which is valid per deb-postinst(5). Add that in for future proofing even though we don't expect it to be called. [1] https://dh-virtualenv.readthedocs.io/en/latest/tutorial.html?highlight=trigger#step-2-set-up-packaging-for-your-project Fixes #6230.
- Loading branch information
Showing
5 changed files
with
1 addition
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
...ble-base/roles/build-securedrop-app-code-deb-pkg/files/securedrop-app-code.triggers-focal
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
install_files/securedrop-app-code/debian/securedrop-app-code.triggers
This file was deleted.
Oops, something went wrong.