Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register trigger on Python for securedrop-app-code package #6231

Merged
merged 1 commit into from
Jan 25, 2022

Commits on Jan 24, 2022

  1. Don't register trigger on Python for securedrop-app-code package

    We currently register a trigger with the Python
    interpreter so dh_virtualenv can fix up the interpreter's symlinks
    in case something changes as recommended in their docs[1].
    
    However, our packages are designed for a single Ubuntu release, which
    keeps the same version of Python for its entire lifetime, so the
    interpreter in the venv will always be a symlink to `/usr/bin/python3`
    and the dh_virtualenv postinst code will always be a no-op because it
    skips all symlinks.
    
    This was noticed because our custom postinst was not handling the
    "triggered" state, which is valid per deb-postinst(5). Add that in for
    future proofing even though we don't expect it to be called.
    
    [1]
    https://dh-virtualenv.readthedocs.io/en/latest/tutorial.html?highlight=trigger#step-2-set-up-packaging-for-your-project
    
    Fixes #6230.
    legoktm authored and Conor Schaefer committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    b64f7a0 View commit details
    Browse the repository at this point in the history