-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachment menu/doc1 page not detected sometimes #291
Comments
Thanks Michael. This looks like a dup of #238. Your solution seems logical to me. Want to take a crack at PR? |
As I said in #238, I don't think we should be looking for a heading at all.
I think this analysis remains correct, 2 years later. So, that is:
Or maybe without even the |
I'm happy with either solution. |
I believe this is fixed via freelawproject/recap-chrome#269 |
I think this is my first bug filed here, apologies if I screwed this up.
Expected behavior w/ example:
Actual behavior on certain doc1 pages:
Suspected cause:
isAttachmentMenuPage
in pacer.js does not detect pages where there is no "Download All" button.Possible (untested!) solution:
isAttachmentMenuPage
, instead or as an alternative to checking for a "Download All" button, check the top bolded text on the doc1 page is "Document Selection Menu".document.getElementsByTagName('b')[0].textContent == 'Document Selection Menu'
Best,
Michael Daniels
The text was updated successfully, but these errors were encountered: