diff --git a/notes/editor-misc.md b/notes/editor-misc.md index 2cb534acd..c481e19b9 100644 --- a/notes/editor-misc.md +++ b/notes/editor-misc.md @@ -5,7 +5,7 @@ - [ ] DEletion does niot work very well at all, need to revisit how this is done. - [ ] When using reference shortcuts (like Event V1, S1 in Mike’s example) do not show concept “EventReference” - [x] Howto add your own editor components to Freon -- [ ] create the ability to jump to elements by clicking (or something) on its reference +- [x] create the ability to jump to elements by clicking (or something) on its reference (special ReferenceBox?) - [ ] When a type of a property cannot be found the error message is rather unclear: (A) - `ERROR: Element 'correctAnswer' should have a type` @@ -14,10 +14,10 @@ - [ ] add a handle for the drag and drop - [x] make it easy to add a button to a component -- [ ] add custom tables +- [x] add custom tables - [ ] maybe add the option to include a vertical line left to an indent component -- [ ] tinymce editor => have a look at MultiLineComponent2.svelte in M&G's stuff +- [x] tinymce editor => have a look at MultiLineComponent2.svelte in M&G's stuff - [ ] Click already selected error in error/search list does not select it in editor. - [ ] Some ersors cannot be navigated to, e.g. placeholders for child concepts @@ -28,7 +28,7 @@ - [ ] Text for found elements should include something readable. - [ ] Enable special projection per element (selectable by the user) -- [ ] Collections as tabbed box (so the elements are stacked upon each other) +- [x] Collections as tabbed box (so the elements are stacked upon each other) - [x] Covered by external components - [ ] Non-textual Box/Component e.g. bodypart picture with click to point to pain areas. diff --git a/notes/expression-editing.md b/notes/expression-editing.md index 7ea7b750f..e7810af13 100644 --- a/notes/expression-editing.md +++ b/notes/expression-editing.md @@ -11,18 +11,18 @@ - [ ] Thereis always a left box with focus before an expression. This is used so people can add operators there, but while gtabbing it feels wrong. How to avoid it? - - solution: when tabbing, skip all the empty places inside expressions (start, end, around binary operators). + - [x] solution: when tabbing, skip all the empty places inside expressions (start, end, around binary operators). - Need to be able to select, so be able to select t hese empty places with the mouse? - Show some special background so people see that they can edit there? -- [ ] Trigger /0-9/. Should not show up in dropdown - - [ ] Never show regular expressions in dropdowns (like `/0-9/`) +- [x] Trigger /0-9/. Should not show up in dropdown + - [x] Never show regular expressions in dropdowns (like `/0-9/`) - [ ] Do not show binary expressions in `left` or `right` placeholders. - People will most probably not use these anyway. - allow the shortcuts? And if so, what about options that are larger than one character? - [ ] If we know something is an identifier (also for references), try not fitting characters in next box. - Similar to the number literal in `samples/Example` - [x] Be able to change the text in “[add]” into something else -- [ ] Deletion in expressions does not work, you get stuck when e.g. a number is empty, delete then jumps to next field +- [x] Deletion in expressions does not work, you get stuck when e.g. a number is empty, delete then jumps to next field #### Binary expressions: diff --git a/notes/freon-bugs.md b/notes/freon-bugs.md index a4e69d880..95292ea8a 100644 --- a/notes/freon-bugs.md +++ b/notes/freon-bugs.md @@ -1,28 +1,62 @@ # Bugs +## Curson incorrectv after optional multi value +After selecting 'implement' with multi-reference in fren lionweb, thge cursor does not go to the right place. +## Incorrect input in action or select box is not cleared when losing focus. +ZDropdownComponent should clean incorrect value in actionbox +In reference box it should keep the incorrect reference +## Error markers in gutter not move with changes in the model +SOmetimes the eror markers do move when something has chnaged in the model, sometimes they do not. +In Example Model89: +- Inserting an attribute at the froms using the context menu: + - The attribute marklers move ok + - The method markers stay where they are, should also move + - NOTE that the attribute markers are on text boxes and the method markers on layout boxes. +## Some error markers stay after projection change, some not +Markers on textboxes (squiggly) stay red after projection change, other markers (in the gutter and the full lines) dissappear +- Is this intentional? +## Any number field that becomes empty deletes the whole node +This is supposed to only work for concepts that have only ons property in their projection, especially the NumerLiteralExpression. +Now e.g. an entity with a version property is deleted when this property becomes empty. +**Problem:** every number box always get deleteWhenEmpty set to true. +**Solution:** remove deleteWhenEmpty as default, add it as custom projection in samples/Example +## Up arrows don't work in select/action boxes +When the dropdown is closed, the up arrow does nothing. +It should go up in the editor to another box. + +**Problem**: The X and Y coordinates of the textbox inside a dropdown component were never set. Reason is that the corresponding text component is not usid througn the renderComponent that sets the X and Y coordinates. + +**Solution**:solved by setting the X and Y explicitly in the text component. May have a better solution when revisiting this. +## ActionBox background remains blue + +The background of a, actionbox become light blue when it is selected/editing. After leaving the actionbox it remains light blue, but it should remove the light blue background. + +- TAB in CLICK out: remains blue +- TAB in TAB out: remains blue +- CLICK in TAB out: ok, blue background dissappears +- CLICK in CLICK out: ok, blue background dissappears + +**Solved**: Dispatch custom 'focusOutTextComponent' when leaving text box ensures it is handled by the textdropdown component. +## After click inside action box TABs and arrows go wrong +When selecting an action box through a click then remove the dropdown using ESC, the TAB, Back TAB and arrow keys use the previous selected box as the starting point + +**Problem**: The selected box is FreEditor is probably not set correctly +**Solved:** By previous two solved problems +## Select and action boxes have no border when selected. +IS this just styling? ## Incorrect projection for expression **Description:** When the AST specifies a specific expression, e.g. for `DocuProject.InsurancePart.risk`, the editor creates a generaic expression projection with a pre- and post- action box. + **Problem:** This is incorrect, as only a NumberLiteralExpression is allowed. -**Solution:** The projection generator should detect that the NumberLiyteralExpression is not a general expression and leave out the pre- and post boxes. +**Proposed Solution:** The projection generator should detect that the NumberLiyteralExpression is not a general expression and leave out the pre- and post boxes. ## Node version (node:55540) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead (Use `node --trace-deprecation ...` to show where the warning was created) -# ActionBox background remains blue - -The background of a, actionbox become light blue when it is selected/editing. After leaving the actionbox it remains light blue, but it should remove the light blue background. - -- TAB in CLICK out: remains blue - -- TAB in TAB out: remains blue - -- CLICK in TAB out: ok, blue background dissappears - -- CLICK in CLICK out: ok, blue background dissappears ## Styling @@ -42,7 +76,7 @@ The cursor should be inside the editor, eg st: - ... -# Box tree error +## Box tree error The following error occurrs: @@ -52,18 +86,12 @@ when selecting method type with click and tryinhg to tab right. The internal textbox parent should be a referencebox. -**Solved:** AbstractSelectBox `children` returned empty array, but should return an array with the internal textbox. +**Solution:** AbstractSelectBox `children` returned empty array, but should return an array with the internal textbox as single element. Done. -## External property replacer cannot inpuit anything +## External property replacer cannot input anything In the external tester project the replacers for properties do not react upon any key stroke. So you cannot type anything.     -# LoggerSettings from webapp-lib to webapp-starter - -See heading - -# Vulnerabilities and warnings when starting webapp - -There are 4 vulnerabilities in node_modules. There are a number of warnings at the startup of the webapp. +## LoggerSettings from webapp-lib to webapp-starter -# Not a bug, but todo: new format for all files on server/modelstore +Then logger setting should be in the webapp-=starter, so the developer can easily change them. diff --git a/notes/known-issues-0.5.0.md b/notes/known-issues-0.5.0.md deleted file mode 100644 index a04af0dcd..000000000 --- a/notes/known-issues-0.5.0.md +++ /dev/null @@ -1,27 +0,0 @@ -# Known Issues in Release 0.5.0 - -## Prio 1 -1. Parameters do not show when all projections are turned off -2. Drag & drop in tabellen werkt niet. -1. Delete in tables does not work. -1. In tables add before does not work. Refresh not ok. - -# Prio 2 -3. At startup first modelunit selection is ok, but focus is missing. - -1. When creating a new node, the selection is on the first editable/selectabe child, but the focus is missing. Both when creating by mouse and keyboard. - -1. When selecting a reference/option in the editor, the selection is on the selected node, but the focus is not. After one TAG the focus dopes go to the selected option. - -1. When dropping a Parameter on another Parameter the Parameter is added to the Method list. - -1. When creating a "base" entity the whole entity is selected afterwards. -2. 1. When tabbing inside tables, the width of the columns changes (slightly) - -1. Arrow up goes wrong with last node at top. -2. Add Plus _sometimes_ goes wrong. E.g. after == . Refresh missing. -3. Click already selected error in error/search list does not select it in editor. -4. Seach for names elements does not find references. -5. Text for found elements should include something readable. -6. Scrollbar for complete app is showing when error panel size is changed. -1. Brackets view does not show brackets. diff --git a/notes/language.md b/notes/language.md index 51b2798d9..e688eef62 100644 --- a/notes/language.md +++ b/notes/language.md @@ -32,7 +32,7 @@ - Especially if certain concepts are not used. Should the custom code for these also be removed? - Need to package reused language as npm package? - [ ] Make Scoper composite -- [ ] Environment should not create the editor, nor the composite projection. +- [ ] FreLanguageEnvironment should not create the editor, nor the composite projection. - [ ] Rename gen/EditorDef.ts ==> "FreLanguage"EditorDef.ts - [ ] All imports should be language dependen - [ ] AllConceptsType should be removed (should be anyway) diff --git a/notes/lionweb.md b/notes/lionweb.md index 427ac5313..dee242aba 100644 --- a/notes/lionweb.md +++ b/notes/lionweb.md @@ -18,10 +18,10 @@ - [ ] Freon alows multi-valued primitive properties, LionWeb does not - [ ] Option 1: remove them from Freon - [ ] Option 2: map to some Freon defined LionWeb structure (and map back) -- [ ] LonWeb has introduced DataType in the M3, Freon does not have it +- [ ] LonWeb has introduced DataType in the M3, Freon does not have it yet - [ ] Option 1: Add DataType to Freon - [ ] Option 2: map to Freon copncept and (harder) map it back -- [ ] LionWeb has annotations, Freon does not +- [ ] LionWeb has annotations, Freon does not yet - [ ] LionWeb has node id's, Freon only secondary - [ ] M2: Look at `id.json` and see how it can be improved. - [ ] M1: $id vs id