Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for standardized logging #997

Open
cwasicki opened this issue Jul 1, 2024 · 1 comment
Open

Add support for standardized logging #997

cwasicki opened this issue Jul 1, 2024 · 1 comment
Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@cwasicki
Copy link
Collaborator

cwasicki commented Jul 1, 2024

What's needed?

We discussed to add support to the SDK to have a standardized way for logging in python actors.

Proposed solution

@llucax proposed to support fine-grained logging configs via the logging.config package.

Use cases

The goal is to have a common way to set log levels on a per actor basis via the config files.

Alternatives and workarounds

No response

Additional context

No response

@cwasicki cwasicki added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Jul 1, 2024
@llucax llucax added this to the Untriaged milestone Jul 2, 2024
@llucax
Copy link
Contributor

llucax commented Jul 22, 2024

TIL we can use the new format()-style placeholders in logging, it just needs some extra config:

https://docs.python.org/3/howto/logging-cookbook.html#formatting-styles

I'm not sure if this is really an option or not, because it will probably break any third-party library (and maybe even linters, that usually interpret logging strings specially), but something we might want to look into.

@llucax llucax modified the milestones: Untriaged, post-v1.0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users
Projects
Status: To do
Development

No branches or pull requests

2 participants