475/adds ckan dataportal #1332
Merged
475/adds ckan dataportal #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great @aivuk! Can you please resolve the conflicts as some API changes have been introduced lately (Manager -> Adapter)? @shashigharti Can you please test and review as I will not be available? |
aivuk
force-pushed
the
475/adds-ckan-dataportal
branch
from
184b292
to
e0648df
Compare
|
@roll I fixed the conflicts but I did need to rebase this branch on main and after that force-pushed the branch again. |
|
@roll @aivuk everything looks great! Added a small comment related to typo. And also this URL ("https://dados.gov.br") in example was not working. |
I changed to legado.dados.gov.br that is working but I don't know until when. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to CKAN as a data portal.