Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question - why not use plugin ? #1

Open
dan-ding opened this issue Feb 20, 2018 · 3 comments
Open

question - why not use plugin ? #1

dan-ding opened this issue Feb 20, 2018 · 3 comments

Comments

@dan-ding
Copy link

Instead of making new adapters, why not just use a plugin with the after method that checks a configuration flag (enabled yes/no)? The way it's written it seems to be acting essentially like an after method.

This would allow other user installed image adapters besides the default two, to work (in most cases) with this extension.

Thoughts?

@barryvdh
Copy link
Member

barryvdh commented May 7, 2018

Could also be, but this seemed appropriate. Are there any other adapters?

@dan-ding
Copy link
Author

I'm not aware of any, yet ;)

but lets' say there were

@dan-ding
Copy link
Author

I'm also asking as I'm unsure if I'm overlooking a reason to the choice made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants