#706 Cuases misbehaviour on server 2008r2

[Vidarls]

System.Environment.SystemDirectory: "C:\Windows\system32"
(environVar SystemRoot): "C:\Windows"

When trying to find .net install dir using targetplatformprefix (https://github.com/fsharp/FAKE/blob/5d1e93e903cc53edd16dee201f48fa09024a71a0/src/app/FakeLib/EnvironmentHelper.fs#L111) it fails due to starting search in system32

Can you please revert until we have a better x-platform fix @forki ?

[forki]

cc @bbenoist
ok will revert.

[Vidarls]

Thanks.

Problem => Have lunch => Problem solved, I could get used to this..

[bbenoist]

My bad, I always use %windir% instead of %SystemRoot% and misleaded it with System.Environment.SystemDirectory by using my System 1 😕

I should have used System.Environment.GetFolderPath(System.Environment.SpecialFolder.Windows) (present since .NET 4.0) instead.

@forki Are you OK to apply the following refactoring and deprecate SystemRoot?

/// The fully qualified path of the Windows directory. Typically "C:\Windows".
let WindowsDirectory = Environment.GetFolderPath Environment.SpecialFolder.Windows

/// The fully qualified path of the system directory. Typically "C:\Windows\System32".
let SystemDirectory = Environment.SystemDirectory

/// Deprecated, please use WindowsDirectory instead.
let SystemRoot = WindowsDirectory

[bbenoist]

Further reading:

• What is difference between %WinDir% and %SystemRoot%?
• Difference between Environment.GetFolderPath(Environment.SpecialFolder.System) and Environment.SystemDirectory for System32 folder
• Environment.SystemDirectory
• Environment.GetFolderPath
• Environment.SpecialFolder
• Environment.cs - Mono
• Environment.cs - .NET Reference Source