Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register custom marks #54

Closed
brianmaissy opened this issue May 30, 2019 · 4 comments
Closed

register custom marks #54

brianmaissy opened this issue May 30, 2019 · 4 comments

Comments

@brianmaissy
Copy link
Contributor

The pytest documentation recommends that plugins register all of their warnings, and since pytest 4.5.0 running tests decorated with unregistered marks emits a PytestUnknownMarkWarning.

I'm happy to open a PR if that sounds ok.

@ftobia
Copy link
Owner

ftobia commented May 30, 2019

That sounds good to me, I'm happy to accept PRs for this.

At the risk of some scope creep for you, while you're in there, would you mind taking a look at ways of running the tests (via TravisCI) against pytest 3.x and 4.x? It's something I haven't kept up on, and e.g. I'd want to make sure that the marker registration doesn't break on earlier versions, or if it does and there's no good way around it, explicitly drop support for earlier versions of pytest. That's the only thing I can see holding up a PR like this.

@brianmaissy
Copy link
Contributor Author

Sure, I'll take a look. By 3.x and 4.x you mean you want to check against the latest 3.x and the latest 4.x, or on all of the versions: [3.1, 3.2, ... 3.10, 4.0, ...] ?

@ftobia
Copy link
Owner

ftobia commented May 30, 2019

More versions are better to test if possible, but I'll settle for just the latest 3.x release and latest 4.x release. I'll trust your judgment if for example you get in there and it's infeasible for whatever reason.

@brianmaissy
Copy link
Contributor Author

It looks like currently pytest-ordering only works on pytest 3.6 and higher, because of the usage of get_closest_marker. Do we want to test only on pytest 3.6 and above (and officially drop support), or fix the backwards compatibility? Related: #48

And if the answer is dropping the support for pytest < 3.6, then since pytest dropped support for python 2.7 and python 3.3 in pytest 3.3, then we should too.

In any case I'll take the opportunity to formalize the supported versions of python and pytest, both in the docs and in setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants