Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade on: "connection" = "keep-alive, Upgrade" #24

Closed
knobo opened this issue Jul 4, 2017 · 2 comments
Closed

upgrade on: "connection" = "keep-alive, Upgrade" #24

knobo opened this issue Jul 4, 2017 · 2 comments

Comments

@knobo
Copy link
Contributor

knobo commented Jul 4, 2017

Firefox sends the header
"connection" = "keep-alive, Upgrade"
instead of
"connection" = "upgrade"
and don't pass the websocket-p function test.
@knobo knobo changed the title Firefox connetion header upgrade on: "connection" = "keep-alive, Upgrade" Jul 4, 2017
@knobo
Copy link
Contributor Author

knobo commented Jul 4, 2017

According to
https://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-14#page-20
point 6, "connection" only need to contain "Upgrade".

@knobo
Copy link
Contributor Author

knobo commented Jul 4, 2017

Suggestion to fix: f7a0639

@knobo knobo closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knobo