Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for canonical tags #44

Open
markoddi opened this issue Apr 20, 2017 · 8 comments
Open

support for canonical tags #44

markoddi opened this issue Apr 20, 2017 · 8 comments

Comments

@markoddi
Copy link

Hi,

How do I make the canonical tag change. I've got the title, description and keywords changing ok.

Do I simply do this:

 {
    path: 'home',
    component: HomeComponent,
    data: {
      meta: {
        title: 'Home page',
        description: 'Description of the home page', 
        canonical: 'mywebsite.com/home' 
      }
    }
  }

I'm using angular version 4, with webpack, typescript and ng2-meta plugin. I just need to make the canonical tag change in runtime like the description changes. Is this possible?

@fulls1z3 fulls1z3 self-assigned this Apr 27, 2017
@fulls1z3 fulls1z3 added this to the v0.2.0-rc.6 milestone Apr 27, 2017
@fulls1z3 fulls1z3 changed the title How do I change the canonical tag ? [enhancement] support canonical tags Apr 27, 2017
@fulls1z3 fulls1z3 changed the title [enhancement] support canonical tags [enhancement] support for canonical tags Apr 27, 2017
@fulls1z3 fulls1z3 modified the milestones: v0.2.0, v0.2.0-rc.6 May 2, 2017
@fulls1z3
Copy link
Owner

fulls1z3 commented May 9, 2017

Hi @markoddi, I've found some useful info on this topic (angular/angular#15776 (comment)).

I am planning to update this repo with this feature, on v0.2.0 final release.

@jesspagan
Copy link

Hi @fulls1z3, I am using v0.4. Is this version going to get an update about this like v.0.2.0??

@fulls1z3
Copy link
Owner

@jesspagan this feature will be implemented both on v0.2.0 and v0.4.0

@fulls1z3 fulls1z3 removed this from the v0.2.0 milestone Sep 3, 2017
@fulls1z3 fulls1z3 changed the title [enhancement] support for canonical tags support for canonical tags Sep 16, 2017
@fulls1z3 fulls1z3 added v5 and removed v4 labels Jan 7, 2018
@fulls1z3 fulls1z3 removed the v5 label Apr 16, 2018
@rafa-suagu
Copy link

@fulls1z3 have you some news about this? If you want I can do a PR with this feature

@fulls1z3 fulls1z3 removed their assignment Nov 22, 2019
@fulls1z3
Copy link
Owner

@rafa-as sorry for the delay, had busy times. feel free to fire a PR and i'll approve.

@d-koppenhagen
Copy link

Probably related to: angular/angular#34605

@rafa-suagu
Copy link

rafa-suagu commented Jan 24, 2020

@d-koppenhagen are you working on a Link Service to do a PR to Angular project?

@d-koppenhagen
Copy link

yes. The PR is already there: angular/angular#34606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants