Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

ListReferenceBasesRequest GET or POST #885

Open
GuilhemSempere opened this issue Nov 9, 2017 · 1 comment
Open

ListReferenceBasesRequest GET or POST #885

GuilhemSempere opened this issue Nov 9, 2017 · 1 comment

Comments

@GuilhemSempere
Copy link

Comparing
http://ga4gh-schemas.readthedocs.io/en/documentation/schemas/referencemethods.html#avro.ListReferenceBasesRequest
with
http://ga4gh-schemas.readthedocs.io/en/documentation/schemas/referencemethods.html#avro.SearchReferencesRequest
I don't understand why the first one is a GET. Unless I am misunderstanding something in the model, what's the point in defining a ListReferenceBasesRequest class if we are meant to pass start & end parameters via the query-string?

@david4096
Copy link
Member

david4096 commented Nov 14, 2017

Hi @GuilhemSempere looks like the documentation needs to be updated since we have changed this endpoint to a POST in the proto. Thanks!

https://github.com/ga4gh/ga4gh-schemas/blob/master/src/main/proto/ga4gh/reference_service.proto#L61

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants