Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to OpenAPI 3.0 #43

Closed
jaeddy opened this issue Jun 15, 2018 · 8 comments
Closed

Bump to OpenAPI 3.0 #43

jaeddy opened this issue Jun 15, 2018 · 8 comments

Comments

@jaeddy
Copy link
Member

jaeddy commented Jun 15, 2018

With major substantive and structural changes happening to the spec en route to v1.0, I wonder if now would also be the best time to bite the bullet and convert to the latest OpenAPI spec. Not sure how much work would be involved, or whether the change would have any major impact on service/client implementors.

@mckinsel
Copy link

The changes don't seem to be too huge. The biggest benefit would probably be that we could correctly specify an arbitrary number of files to upload for workflow_descriptor.

For me, the biggest drawback is that there seems to be less tooling for openapi 3. For example, AWS API Gateway doesn't appear to work with it.

@denis-yuen
Copy link
Member

Same here, we've been poking around at OpenAPI 3, but swagger-codegen is almost but not quite ready for compatibility. https://github.com/swagger-api/swagger-codegen#compatibility

@jaeddy
Copy link
Member Author

jaeddy commented Feb 11, 2019

See (and track) ga4gh/data-repository-service-schemas#230

@brainstorm
Copy link

@denis-yuen See ga4gh/data-repository-service-schemas#230 (comment), hope that helps, it worked for me with htsget and Rust:

openapi-generator generate -i spec/htsget-openapi.yaml -g rust -o src/htsget-client
openapi-generator generate -i spec/htsget-openapi.yaml -g rust-server -o src/htsget-server

(After brew install openapi-generator, that is).

@jaeddy
Copy link
Member Author

jaeddy commented Feb 25, 2019

Thanks, @brainstorm! I'll check that out.

@wshands— can you provide some detail for the code-gen client failures you've observed for OpenAPI 2.0 and 3.0?

@wshands
Copy link
Collaborator

wshands commented Feb 26, 2019

The error I saw was that contents of the files in the workflow attachment are not included in a POST request and seems to occur in both the Swagger and OpenApi code generators. I submitted these two issues:
swagger-api/swagger-codegen#9195
OpenAPITools/openapi-generator#2210

@denis-yuen
Copy link
Member

@brainstorm thanks for the tip, in a different issue much later we found that swagger-codegen 3.0.4 also works ga4gh/data-repository-service-schemas#230 (comment)

@patmagee
Copy link
Contributor

Closing this as it looks like our API spec is currently on v 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants