Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throwing exceptions at line_logger destructor #214

Closed
sryio opened this issue May 19, 2016 · 2 comments
Closed

throwing exceptions at line_logger destructor #214

sryio opened this issue May 19, 2016 · 2 comments

Comments

@sryio
Copy link

sryio commented May 19, 2016

Hi, when I using spdlog on android with android sink, I found spdlog may throwing exceptions in line_logger's destructor, and cannot be catched by my outer functions, which cause crashes.

spdlog::details::line_logger::~line_logger()
-> _callback_logger->_log_msg(_log_msg)
-> sink->log(msg)
-> base_android_sink::_sink_it()
->throwing spdlog_ex
-> crash

@gabime
Copy link
Owner

gabime commented May 19, 2016

related to #136

@gabime
Copy link
Owner

gabime commented Jul 11, 2016

Fixed. line_logger removed after (removing streaming API)

@gabime gabime closed this as completed Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants