adding support for docker stack config #510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `docker stack config` command returns a yaml content on stdout. We have to parse the yaml output, hence the new pyyaml requirement. The parameter "return_json" like the `ComposeCLI.config` method. + a couple of tests
gabrieldemarmiesse
requested changes
Nov 29, 2023
- moved pyyaml dep from requirements.txt to pyproject.toml (user will have to install python_on_whales[yaml] to have it) - handle missing dependency in stack/cli_wrapper.py - add pyyaml in test-requirements.txt
|
😬 I forgot to add a docstring and I don't have the time to do it for the moment, sorry |
|
No worries, we're not in a hurry. In the open source world, we have all the time we want |
gabrieldemarmiesse
requested changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docker stack configcommand returns a yaml content on stdout. We have to parse the yaml output, hence the new pyyaml requirement.The parameter "return_json" like the
ComposeCLI.configmethod.fix: #509