Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for pydantic v1 #594

Closed
1 task done
LewisGaul opened this issue May 25, 2024 · 0 comments · Fixed by #630
Closed
1 task done

Drop support for pydantic v1 #594

LewisGaul opened this issue May 25, 2024 · 0 comments · Fixed by #630
Labels
good first issue Good for newcomers

Comments

@LewisGaul
Copy link
Collaborator

LewisGaul commented May 25, 2024 •
edited
Loading

The pydantic version policy says v1 support will be stopped at the end of June 2024, at which point we can also drop support.

  • Remove any code that checks the pydantic version (search for pydantic.VERSION)

  • Restrict the version in requirements.txt (which is also used by the packaging via pyproject.toml)

  • Stop parameterising over pydantic versions in the CI

  • Wait for pydantic to drop support for v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop support for pydantic v1 LewisGaul/python-on-whales
1 participant
@LewisGaul