-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox Version? #33
Comments
It might, but currently it's deeply tied with chrome's API, in terms of code structure. A firefox port would probably have to be rewritten for firefox specifically. I'll try to keep this in mind, but for now I'm not sure if I'd have the time to do it. |
How about publishing this as css via userstyles.org to be used with the Stylish add-on(firefox)? |
Feel free to contribute |
Firefox support has been added with the efforts of @ColdenCullen and myself. You can download the .xpi from the Releases section of my fork. To add the extension to Firefox, just drag the .xpi into the Addons window. Feel free to report any bugs you find in this issue, I don't want to open the issue tracker on my fork since the goal would be to get this merged upstream once everything works. |
Awesome, finally I can sanely browse HN comment threads. Thanks to both of you. |
👍 |
Closed with the merge of #65 |
Unfortunately, The .xpi files served on the releases page don't appear to be signed as firefox doesn't allow installation of those anymore. |
Ah ha, someone noticed! Let me list out the options and plan of attack:
Clearly the latter option is the best option long-term. We've actually tried two submissions the last few months. The first review failed and resulted in issue #88. The second review failed for the same reason since we hadn't fixed the problem, but we thought it would be OK since the automated reviewer doesn't flag innerHTML as an error anymore and I wrote up a good justification for why our usage of it should be allowed. I've spent a couple hours replacing our innerHTML usage throughout the addon, and I need to spend some more time making it all work without regressions. With Firefox v48 removing the ability to load unsigned addons, I have more incentive to get it done and try once again to get it into Firefox Addons. If there is enough interest I can definitely go with the first option listed earlier and get a signed version released on Github as a short-term fix. |
I've gone ahead and submitted v1.4.8 to the Firefox Addons review team without all the innerHTML fixes, but a lot of justification text for why it should be allowed. If they deny it yet again from the Addons store, I will post a self-signed release here. |
Would it be possible to port this to Firefox?
The text was updated successfully, but these errors were encountered: