Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken header when black commemoration bar is added #81

Open
benbristow opened this issue Nov 13, 2015 · 6 comments
Open

Broken header when black commemoration bar is added #81

benbristow opened this issue Nov 13, 2015 · 6 comments
Labels

Comments

@benbristow
Copy link

HackerNews have added a weird black bar to the top of the pages, and now the header is broken.

broken

@ethanve
Copy link

ethanve commented Nov 13, 2015

+1

1 similar comment
@rzhou186
Copy link

+1

@gabrielecirulli
Copy link
Owner

Thanks for the report. I'll have a look.

@gabrielecirulli
Copy link
Owner

As mentioned in #86, it happens when someone dies and HN puts up the black bar to commemorate them. As there's no way to know what the HTML of the page looks like right now, we can only fix it when the bar appears again.

Sounds pretty macabre, but we will probably have to wait for someone else's death before we can fix this entirely.

@gabrielecirulli gabrielecirulli changed the title Broken header Broken header when black commemoration bar is added Jul 27, 2016
@gabrielecirulli
Copy link
Owner

I've captured a snapshot of the page with the black band in case I won't have time to address the issue while it's still there: https://gist.github.com/gabrielecirulli/07fda6a01c3943f4fdb2d123caddf35f

@gabrielecirulli
Copy link
Owner

It also seems like the black band HTML has changed since when this issue was reported, because it renders differently:

hacker news 2016-08-01 10 pm-31-19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants