-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out the API for nested drop targets #87
Comments
I assign this to 0.9 milestone because I think this can be done in backward-compatible way. |
#90 is a nested example that seems to work without any use of the event... Not sure if their are other use cases... I will do some testing on my kanban branch. |
I think we figured it out in dnd-core, so I'm closing this one. To sum up:
|
Sorry guys. |
@deser Currently we don't expose a way to know from |
@deser We do however expose |
Thanks a lot! |
Added bottom shadow to the table if there is possibility to scroll down.
@deser This is now exposed in 1.0. You can compare |
Great job! Thanks a lot!)) |
Is there an example of this? What does comparing |
We want to support nested drop target, but make it easy for parent targets to opt out of events when children are active. We have several requirements:
e
argument fore.stopPropagation
and the likes. Ideally, we'll deprecatee
and stop passing it in 1.0.over
(e.g. to scroll the view) even if it doesn't handle drag. For this reason, each drop target should be able to decide on its own whether it wants to react to drop and whether it needs to hover.We already note nesting in
acceptDrop
: ifisHandled
istrue
, this means some child has already handled drop before us (and parent may decide not to do anything in this case). We need a similar API forenter
/over
/leave
as well as theirthis.getDropState(type).isHovering
counterpart.#85 starts this work by adding a nested dustbin example. We want to find a good API to make it work.
There's an attempt at adding API for this in #76 but it's currently too noisy. @itrelease, can you please write down the API you're proposing there? Or else you can reimplement it on top of #85 so we can see where you're heading.
This issue supersedes #75.
The text was updated successfully, but these errors were encountered: